Issue #22330 has been updated by Charlie Sharpsteen.

Status changed from Unreviewed to Needs More Information
Assignee set to James Ralston

Hi James,

Thanks a bunch for the patch! If you could submit a pull request to the [Puppet 
project on GitHub](https://github.com/puppetlabs/puppet) the engineering team 
will review it for inclusion. Directions for submitting pull requests can be 
found in the file 
[CONTRIBUTING.md](https://github.com/puppetlabs/puppet/blob/master/CONTRIBUTING.md)

Let us know if you have any questions!

----------------------------------------
Bug #22330: add btrfs to SELinux filesystem whitelist
https://projects.puppetlabs.com/issues/22330#change-96974

* Author: James Ralston
* Status: Needs More Information
* Priority: Normal
* Assignee: James Ralston
* Category: SELinux
* Target version: 3.x
* Affected Puppet version: development
* Keywords: 
* Branch: 
----------------------------------------
I currently run Puppet on btrfs filesystems using Fedora 18 and Fedora 19, and 
I noticed that Puppet was not correcting SELinux file contexts, even though the 
libselinux-ruby package was installed.

Upon investigation, I realized that Puppet has an explicit whitelist of 
filesystems known to support SELinux file contexts, and btrfs wasn't in the 
list.

The btrfs filesystem has supported SELinux file contexts (file xattr) since 
2009, and it is highly unlikely that any version of btrfs older than that will 
be seen in the wild.  (In 2009, about the only people using btrfs were btrfs 
developers, and they have long since migrated to more recent versions.) 
Therefore, I would submit that it is appropriate to whitelist btrfs as a 
SELinux-capable filesystem.
    
I've tested the attached patch, and assert that with it, Puppet SELinux file 
labeling works properly on btrfs filesystems.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to