Issue #22233 has been updated by Andrew Parker. Status changed from Unreviewed to Needs More Information Assignee changed from Eric Johnson to Jeff McCune
This has been merged, but caused several breaks in our tests. Fixes for those breaks were submitted in a PR and merged in <https://github.com/puppetlabs/facter/commit/eed19ed3c064eb485fc8b27847147600cb805a63>. Jeff, you merged this code, but I don't think it would normally have passed our standards (method names and docs don't match method implementation, for instance). Could you please make sure that the code is good and everything has been updated correctly? For instance, this issue wasn't updated. ---------------------------------------- Feature #22233: Add support for Google Compute Engine into facter core https://projects.puppetlabs.com/issues/22233#change-97037 * Author: Eric Johnson * Status: Needs More Information * Priority: Normal * Assignee: Jeff McCune * Category: cloud - gce * Target version: 1.7.x * Keywords: gce * Branch: gce * Affected Facter version: ---------------------------------------- Add support into core for puppet nodes running in Google Compute Engine. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
