Issue #22652 has been updated by Josh Cooper.

The agent sends a POST request if the [total length exceeds 
1K](https://github.com/puppetlabs/puppet/blob/master/lib/puppet/indirector/rest.rb#L91-L97)
 . It appears rack's `Request#params` returns the "union of GET and POST data" 
whereas `Request#query_string` will not obviously. We may be able to combine 
the two approaches and do something like:

<pre>
def params(request)
  result = decode_params(request.params)
  query_params = CGI.parse(request.query_string)
  convert_singular_arrays_to_value(query_params)
  result.merge!(query_params)
  result.merge(extract_client_info(request))
end
</pre>

For `ignore`, the `request.params` method will truncate the list, but then we 
parse the `query_string` and that overrides the value from `request.params`.

For `facts`, the `request.params` method will return the complete set (as it 
did before), and since they are not in the query_string, we'll get the same 
behavior as before.

----------------------------------------
Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-98012

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938
----------------------------------------
/var/lib/puppet/..../.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to