Issue #9203 has been updated by Andrew Forgue.

Got bitten by this again today, would love to see it fixed.

----------------------------------------
Bug #9203: Change namespace for semver.rb
https://projects.puppetlabs.com/issues/9203#change-98646

* Author: darix .
* Status: Accepted
* Priority: High
* Assignee: Jeff McCune
* Category: API
* Target version: 
* Affected Puppet version: 2.7.3
* Keywords: semver
* Branch: 
----------------------------------------
1. your copy of the file differs from 
https://github.com/flazz/semver/blob/master/lib/semver.rb

wouldnt it be better to move the changed copy into the puppet namespace to 
avoid problems when people require semver and expect to get the gem version?

2. I couldnt find a reference to the license of the file neither in the 
"upstream" git nor in your copy. 

3. shouldnt the readme mention that you include code from 
https://github.com/flazz/semver

4. how about depending on the gem instead of copying the code?


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to