Issue #18295 has been updated by Andrew Parker. Status changed from Merged - Pending Release to Closed
Released in 3.3.0 ---------------------------------------- Bug #18295: Windows Package installer_options not quoted when when source contains spaces https://projects.puppetlabs.com/issues/18295#change-99450 * Author: Nathan Buuck * Status: Closed * Priority: Normal * Assignee: * Category: windows * Target version: 3.3.0 * Affected Puppet version: 3.0.2 * Keywords: windows package * Branch: https://github.com/puppetlabs/puppet/pull/1732 ---------------------------------------- **Synopsis**: When the puppet agent's "windows:" provider generates the Windows shell command to execute a self-extracting executable installer, the "installer_options" like "/s" are left outside of the double-quotes that enclose the "source". This causes the package's installer_options to be appended as if they're switches for the "start" process, which almost always causes the installation to fail. **Example**: package { "Mozilla Firefox 17.0.1: ensure => installed, source => '\\NAS\Software\Mozilla\Firefox 17.0.1.exe', installer_options => [ '/s' ] } The agent will attempt to execute a command similar to this (from memory, I'm afraid; the cmd.exe and start arguments may be swapped): cmd.exe /c start /w "\\NAS\Software\Mozilla\Firefox 17.0.1.exe" /s Where as it should attempt to execute: cmd.exe /c start /w "\\NAS\Software\Mozilla\Firefox 17.0.1.exe /s" **Other Notes**: 1. The issue occurs regardless of specifying the provider attribute of the package. 2. The agent was running on Windows 7 Professional x64. 3. The agent was Puppet Open Source 3.0.2 for Windows, installed silently via .MSI from http://puppetlabs.com/misc/download-options/ -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
