Issue #6409 has been updated by Andrew Parker.

Released in 3.3.0

----------------------------------------
Bug #6409: Mount provider should reject spaces in fstab fields
https://projects.puppetlabs.com/issues/6409#change-99523

* Author: Paul Berry
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: mount
* Target version: 3.3.0
* Affected Puppet version: 
* Keywords: mount fstab
* Branch: https://github.com/puppetlabs/puppet/pull/1699
----------------------------------------
This is accepted by Puppet:

    mount { '/Volumes/NIKON D40X': ensure => unmounted, device => 
"/dev/disk1s1", fstype => msdos }

But (at least on Mac OS X) it causes problems, because it causes an fstab entry 
to be created that has a space in the mount point:

    /dev/disk1s1        /Volumes/NIKON D40X     msdos           0       0

According to mac's fstab man page, fstab fields are separated by whitespace, so 
the "D40X" gets interpreted as the fstype, which obviously doesn't work.

Additionally, the next time Puppet needs to change the fstab file, it will 
change the space to a hard tab, leaving a new entry behind for every single 
puppet run.  For example:

    /dev/disk1s1        /Volumes/NIKON  D40X    msdos   0       0
    /dev/disk1s1        /Volumes/NIKON  D40X    msdos   0       0
    /dev/disk1s1        /Volumes/NIKON D40X     msdos           0       0


It seems likely that similar problems exist on most OSes.

It seems like an easy and sufficient solution to this problem is to prohibit 
spaces in the properties of mount resources.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to