Issue #21801 has been updated by Andrew Parker.
Released in 3.3.0 ---------------------------------------- Bug #21801: Client-enabled profiling does not work under Passenger https://projects.puppetlabs.com/issues/21801#change-99586 * Author: eric sorenson * Status: Closed * Priority: Normal * Assignee: * Category: network * Target version: 3.3.0 * Affected Puppet version: * Keywords: * Branch: https://github.com/puppetlabs/puppet/pull/1778 ---------------------------------------- In #17190, we built out profiling for catalog compilations, which should be trigger-able from an agent by adding the '--profile' command line option. There have been a couple of reports of this not working, and it turns out that it works under Webrick but not passenger. Digging in a bit, I added a debug line to https://github.com/puppetlabs/puppet/blob/master/lib/puppet/network/http/handler.rb#L342 and saw that the match was failing due to Rack's transformation of the http headers (as described [here](http://stackoverflow.com/questions/6317705/rackrequest-how-do-i-get-all-headers) <pre> Jul 16 22:44:52 master puppet-master[21058]: Dumping request headers, look for profiling {"x_ssl_subject"=>"/CN=master", "connection"=>"close", "user_agent"=>"Ruby", "host"=>"master:8140", "accept"=>"pson, b64_zlib_yaml, yaml, raw", "x_client_verify"=>"SUCCESS", "x_client_dn"=>"/CN=master"} </pre> Since we're matching only the hyphenated version of the header, this fails. I tested by adding another case which gsub's the `-` to `_` and profiling showed up as I expected. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
