Issue #22699 has been updated by Melissa Stone.

Released in Puppet 3.4.0-rc1

----------------------------------------
Bug #22699: Boolean parameters/properties (introduced in 3.3) no longer create 
value_collections
https://projects.puppetlabs.com/issues/22699#change-100746

* Author: Nick Fagerlund
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 3.4.0
* Affected Puppet version: 3.3.0
* Keywords: regression boolean parameter valuecollection reference
* Branch: https://github.com/puppetlabs/puppet/pull/1947
----------------------------------------
Commit ba7576d3ca6ec681301de83562ec8fd3b8207a8d ("Add DRY support for boolean 
parameters," first shipped in 3.3.0-rc1) caused boolean parameters to bypass 
the `value_collection` mechanism for declaring allowed values. (The `newvalue` 
and `newvalues` methods inside a parameter block cause new values to be added 
to the `value_collection` attr of that parameter; the `value_collection` can be 
queried once the type is loaded.)

This broke the type reference. The #doc method of Puppet::Parameter expects 
that all valid values will be queryable from the `value_collection` (`@doc += 
value_collection.doc` around line 119-ish), and now that it's empty, boolean 
parameters look like they take arbitrary strings instead of strictly limited 
values.

This should be fixed by causing boolean parameters to fill in their 
`value_collection` appropriately, so we can have a single reliable way to 
determine allowed values.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to