Issue #23368 has been updated by Ethan Brown. Status changed from In Topic Branch Pending Review to Merged - Pending Release
---------------------------------------- Bug #23368: Script based external facts fail on Windows 2003 https://projects.puppetlabs.com/issues/23368#change-101130 * Author: Josh Cooper * Status: Merged - Pending Release * Priority: Normal * Assignee: * Category: * Target version: 1.7.4 * Keywords: windows * Branch: https://github.com/puppetlabs/facter/pull/569 * Affected Facter version: 1.7.0 ---------------------------------------- Facter's ScriptParser will execute external facts with extensions (bat, cmd, com, exe) using ruby's `%x{ }`. On 2003, the path to these files will contain a space, e.g. `C:\Documents and Settings\All Users\Application Data\PuppetLabs\facter\facts.d`. Since the command is not quoted, it will fail (it's interpreted as the command `C:\Documents` with arguments `and`, `Settings\All`, etc. It is not an issue on 2008 and later, because the path to the script does not typically contain a space, `C:\ProgramData\PuppetLabs\facter\facts.d`. It is not an issue with Powershell scripts, because there is a powershell specific parser that executes `powershell -File 'path/to/file.ps1'` It is not an issue for text based external facts, because `File.read` does not require the path to be quoted. The fix is simple, make sure the path is quoted if it contains spaces. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
