Issue #23311 has been updated by Felix Frank.

OK, so this seems to fix this (specs have not run yet)

<pre>
--- a/lib/puppet.rb
+++ b/lib/puppet.rb
@@ -145,9 +145,9 @@ module Puppet
   # private helper method to provide the implementation details of 
initializing for a run mode,
   #  but allowing us to control where the deprecation warning is issued
   def self.do_initialize_settings_for_run_mode(run_mode, args)
-    Puppet.settings.initialize_global_settings(args)
     run_mode = Puppet::Util::RunMode[run_mode]
     
Puppet.settings.initialize_app_defaults(Puppet::Settings.app_defaults_for_run_mode(run_mode))
+    Puppet.settings.initialize_global_settings(args)
   end
   private_class_method :do_initialize_settings_for_run_mode
 
</pre>

There are still some weird things I don't get though: This is reproducible when 
running the agent as root and removing vardir= from the conf file but using 
$vardir there. <b>But</b> it's not reproducible when doing the same in a 
regular user's conf.

Currently, the issue can be worked around by not using $vardir in puppet.conf 
(but at least the default one in the Debian package does just that).

----------------------------------------
Bug #23311: vardir default in 3.3.2
https://projects.puppetlabs.com/issues/23311#change-101187

* Author: James Eckersall
* Status: Accepted
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: 
* Branch: 
----------------------------------------
Hi,

I'm suffering from what looks to be the same or related bug 
http://projects.puppetlabs.com/issues/16637

I have an infrastructure of approximately 500 nodes managed by Puppet.  They 
were all running 2.7.22 and today I've come to upgrade them all to 3.3.2.

The boxes are a mix of CentOS and RedHat, EL5 and EL6.

We manage Puppet with Puppet, so today I updated the manifest to point to the 
updated rpm's in the repo and let it rip.

Most of my nodes are now failing to even start Puppet with the following error:

Error: Could not intialize global default settings: Error converting value for 
param 'factpath': Could not find value for $vardir

If I add the below line to /etc/puppet/puppet.conf, all is good with the world.
vardir = /var/lib/puppet

That line did not previously exist in the puppet.conf file, so it looks like 
the upgrade to 3.3.2 has introduced this bug.

Now I'm faced with the unpleasant task of manually deploying a script to each 
node to insert that line as Puppet now refuses to start on my nodes.

I can easily replicate this.  Remove that line from puppet.conf and the agent 
will not start ("service puppet start" or "puppet agent --test" as root).

J


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to