Jira (PUP-1246) Hiding error details in fileserver.conf parser when this config is wrong

[Alexei Romanov (JIRA)]

Title: Message Title

Alexei Romanov created an issue   Puppet / PUP-1246 Hiding error details in fileserver.conf parser when this config is wrong Issue Type: Bug Affects Versions: 3.3.3, 3.3.2 Assignee: Alexei Romanov Attachments: fileserver.conf, fix_file_serving_parser_error_handling.diff, test.pp Components: Community Created: 26/Dec/13 6:33 AM Environment: Ubuntu 12.04.3 LTS (GNU/Linux 3.2.0-57-generic x86_64) ruby 1.8.7 (2011-06-30 patchlevel 352) [x86_64-linux] Labels: puppet-fileserver Priority: Normal Reporter: Alexei Romanov When I try to apply simple manifest test.pp which is just tries to copy file from puppet master using puppet:// schema, I receive following error at client node: Error: /Stage[main]//File[/tmp/example-file.txt]: Could not evaluate: Error 403 on SERVER: Forbidden request: mel4102.melesta.local(10.32.32.111) access to /file_metadata/custom_files/example-file.txt [find] at :129 Could not retrieve file metadata for puppet://puppet/custom_files/example-file.txt: Error 403 on SERVER: Forbidden request: mel4102.melesta.local(10.32.32.111) access to /file_metadata/custom_files/example-file.txt [find] at :129 At puppet master logs, when I run it in foreground with this command line sudo puppet master --debug --no-daemonize I've found following error: Error parsing fileserver configuration: wrong number of arguments (3 for 1); using old configuration I've spend half of my working day for debugging this issue and I've discovered than this it happens when there is some invalid line in /etc/puppet/fileserver.conf. In my case it was some strange symbols '\xc2\xa0\xc2\xa0' occured in this file, probably after copy-pasting from my browser window into fileserver.conf. My next step was to look into fileserver.conf parser and I've found the bug in lib/puppet/file_serving/configuration/parser.rb. Because of invalid raising an ArgumentError exception, actual useful information about mistakes in fileserver.conf is lost. I think this behaviour is wrong and should be fixed. Here is the simple patch with fixing of this mistake + 2 test-cases. I'll create a pull request after filling this bug ASAP. Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.