Jira (PUP-1362) Rubyize yumhelper.py to remove dependency on python

[Jason Antman (JIRA)]

Title: Message Title

Jason Antman commented on an issue   Re: Rubyize yumhelper.py to remove dependency on python The Redmine ticket has quite a bit of discussion around whether shelling out to yum is the right solution, or whether the python wrapper should just be made more robust, or... ? There's a PR (https://github.com/puppetlabs/puppet/pull/1205) by Alex Cline that was closed 4 months ago as it was lacking both tests and was showing merge conflicts. The last comment from Alex indicated that this is no longer needed for his environment and he doesn't have desire to continue development. I can't really comment on ruby-izing this... that's beyond my ruby knowledge (at least to evaluate how to do so safely). However, since yumhelper.rb just shells out itself if it can't import the yum module (which is strange, because yum itself depends on the yum module), I don't see why that logic can't be moved to ruby. I can, however, throw in a few useful comments: 1) we should figure out how to unit test yumhelper.rb. Even if that's a manual process... 2) yumhelper.rb is being executed with whatever yum happens to be first in path, which isn't necessarily right. If we're going to continue using yumhelper.rb, we should find the path to yum (usually /usr/bin/yum) and parse the she-bang from that, as that will give us the path to the python that should run yum on the system. Usually, this is /usr/bin/python (actually I've never seen it be anything else, as that's hard-coded into the yum script). Add Comment   Puppet / PUP-1362 Rubyize yumhelper.py to remove dependency on python There are several bugs (bug 11380 being one that triggered this patch) that highlight the fact that the version of python used as the default on a system running puppet can break yumhelper.py. This refactor removes yumhelper.py and moves the functionality into the Yum provider in puppet. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.