Jira (PUP-1421) appdmg prematurely filters for sources ending in .dmg

Jonathan Webb (JIRA) Sun, 12 Jan 2014 08:04:23 -0800

Title: Message Title

Jonathan Webb created an issue

PUP-1421

Issue Type:	Bug
Affects Versions:	3.3.1
Assignee:	Unassigned
Components:	Types and Providers
Created:	12/Jan/14 8:03 AM
Environment:	Mac OS 10.9, using Puppet 3.3.1 via boxen/our-boxen
Priority:	Normal
Reporter:	Jonathan Webb

Problem

The following package resource:

                                                    package { 'Toggl':
  provider => 'appdmg',
  source   => 'https://www.toggl.com/api/v8/installer?app=td&platform=darwin&channel=stable'
}

                                                

Fails with:

                                                    Error: Could not set 'present' on ensure: private method `fail' called for Puppet::Type::Package::ProviderAppdmg:Class at [manifest line]

                                                

Root Cause

In lib/puppet/provider/package/appdmg.rb the installpkgdmg method starts out by validating that the source ends with .dmg:

                                                      def self.installpkgdmg(source, name)
    unless source =~ /\.dmg$/i
      self.fail "Mac OS X PKG DMG's must specify a source string ending in .dmg"
    end
    # ... proceeds with downloading the source

                                                

In the example above Toggl has a download URL which is an abstraction to redirect to the latest version:

                                                    https://www.toggl.com/api/v8/installer?app=td&platform=darwin&channel=stable

                                                

Redirects to the latest version, which is currently:

                                                    https://55aa37393ef0d1f9fb76-e65c36a55026053efe5868c3826f43f1.ssl.cf1.rackcdn.com/TogglDesktop_2013-10-17-13-05-57.dmg

                                                

Incidentally the download is curled to whatever "name" is, and "name" is what is ultimately mounted (and this will mount without the .dmg extension). With the validation commented out:

{notice}
Debug: Executing '/usr/bin/curl -o /tmp/d20140112-38340-1k8oyhr/Toggl -C - -k -L -s --url https://www.toggl.com/api/v8/installer?app=td&platform=darwin&channel=stable'
Debug: Success: curl transfered [Toggl]
Debug: Executing '/usr/bin/hdiutil mount -plist -nobrowse -readonly -mountrandom /tmp /tmp/d20140112-38340-1k8oyhr/Toggl'
Debug: Executing '/usr/bin/ditto --rsrc /private/tmp/dmg.fJGJa8/TogglDesktop.app /Applications/TogglDesktop.app'
Debug: Executing '/usr/bin/hdiutil eject /private/tmp/dmg.fJGJa8'
Notice: /Stage[main]/Toggl/Package[Toggl]/ensure: created{notice}

This issue was discovered in 3.3.1, but appdmg.rb hasn't changed significantly since then (as of 3.4.2).

I will submit a PR with the fix.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

Jira (PUP-1421) appdmg prematurely filters for sources ending in .dmg

Problem

Root Cause

Reply via email to