Jira (PUP-1150) Race condition in Puppet::Util::Lockfile

[Peter Huene (JIRA)]

Title: Message Title

Peter Huene commented on an issue   Re: Race condition in Puppet::Util::Lockfile I've verified the changes fix the race by adding a delay between the #locked? check and the call to create the lock file and by removing the #locked? call entirely, although we have another spec that depends on #lock calling #locked?. Changes look good, except I think the new spec to test the race can be improved (i.e. forking ten processes once and ensure only one process acquired the lock instead of forking only two processes five times). Add Comment   Puppet / PUP-1150 Race condition in Puppet::Util::Lockfile Puppet::Util::Lockfile does not exclude other processes from acquiring a lock between the time it checks if the lock file exists and when it writes to the lock file. This allows for a race condition, and two puppet processes started simultaneously are likely to acquire the same lock. This has been witnessed in the wild where I work because we may have... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.