Jira (PUP-684) Namevar over 1024 characters is not caught and results in invalid yaml with accompanying errors

[Mark Chester (JIRA)]

Title: Message Title

Mark Chester commented on an issue   Re: Namevar over 1024 characters is not caught and results in invalid yaml with accompanying errors We ran into this today. Our SSH public keys are stored in Hiera and I needed to verify the module was getting the SSH key data from Hiera, so I added a notify right before creating the resources. The result of the Hiera query is half a dozen user key records, which all in one big lump becomes the namevar for notify. The associated line in state.yaml was almost 4000 characters long overall. I fixed the state.yaml file on the node by deleting offending lines from /var/opt/lib/pe-puppet/state/state.yaml. I am not sure it is safe to simply remove lines from state.yaml. Ticket description says to delete the file, which I may end up having to do. My usage of the notify type could be considered bad, and proper usage would not have exposed this bug. But so many examples on the 'Net use this form of notify that it has become a bad/lazy habit (which I have broken as of today). In Hiera: SNIP *** sshkeys::myagency: User One: key: 'AAAAB3NzaC1yc2EAAAADAQABAAABAQDT64IBSrHI4Cs9kAMUL8ZPPSSRVj+nRc2R1dhT+UEck+eXbx+Gva52FertnYF1ze6NKmXn6zNwC1/4d/JeATdLr76wu7L7vcCujSk3C9WGbiIqSeIxV1Fs8PBDx3DP4hFeMk8C6zoanWQgZcEqTy+WQHMn6BrQaCAOUUlZhgGagiL8bPl/xWKOWClEHYVHbRPmJrbU5XzBQcqcLuHfuzOEa5G+AEE7nFcM2b7JQNLYaKhI2DX5zKYB4gUeKL7GjMadHooyYA/7xba+klHBi3Ux8GvKUpwOIaczhwakZ2rlaECnr57PgtwXE8bgfw8DAcE6pIkFkhdmLeGWwIzpfq4r' type: ssh-rsa user: uone SNIP *** In the module: ... $keylist = hiera_hash("sshkeys::myagency", '') ... notify { "The list of keys is: $ {keylist} ": } ... Yields this error: [root@puppet-node pe-puppet]# puppet agent --test Error: Could not run Puppet configuration client: (<unknown>): could not find expected ':' while scanning a simple key at line 3013 column 3 Error: Could not run: can't convert Puppet::Util::Log into Integer Mark- Add Comment   Puppet / PUP-684 Namevar over 1024 characters is not caught and results in invalid yaml with accompanying errors Puppet resources with namevars over 1024 characters result in the generation of invalid yaml. For example, this nonsense resource: ssh_authorized_key { 'fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.