Jira (PUP-1511) Puppet help doesn't display a useful message when a module raises LoadError

[Joshua Cooper (JIRA)]

Title: Message Title

Joshua Cooper created an issue   Puppet / PUP-1511 Puppet help doesn't display a useful message when a module raises LoadError Issue Type: Bug Affects Versions: 3.4.2 Assignee: Eric Sorenson Created: 24/Jan/14 9:31 AM Priority: Normal Reporter: Joshua Cooper The help face-based application only rescues Puppet::Errors, so if it tries to load a module that, for example, has a dependency on a gem that is not installed, then puppet silently exits with 1: 0 ~/work/puppet (master) $ be puppet module install msopentech-windowsazure Notice: Preparing to install into /Users/josh/.puppet/modules ... Notice: Downloading from https://forge.puppetlabs.com ... Notice: Installing -- do not interrupt ... /Users/josh/.puppet/modules └── msopentech-windowsazure (v1.1.1) 0 ~/work/puppet (master) $ be puppet help 1 ~/work/puppet (master) $ Something like this seems to fix the problem, though faces seems to only rescue Puppet::Errors in other places as well: diff --git a/lib/puppet/face/help.rb b/lib/puppet/face/help.rb index 44380ab..713d57e 100644 — a/lib/puppet/face/help.rb +++ b/lib/puppet/face/help.rb @@ -140,7 +140,9 @@ Detail: "# {detail.message} " begin face = Puppet::Face[appname, :current] result << [appname, face.summary] rescue Puppet::Error + rescue SystemExit,NoMemoryError + raise + rescue Exception => e result << [ "! # {appname} ", "! Subcommand unavailable due to error. Check error logs." end Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.