Jira (MCO-176) Windows service cannot be paused

[Peter Huene (JIRA)]

Title: Message Title

Peter Huene created an issue   MCollective / MCO-176 Windows service cannot be paused Issue Type: Bug Affects Versions: 3.X.0 Assignee: Pieter Loubser Components: Platform Created: 30/Jan/14 5:07 PM Priority: Normal Reporter: Peter Huene The mcollective service on Windows cannot be paused, only stopped. If a user pauses the service via the service control manager, the service itself will enter a paused state, but mcollective continues performing work. This may be confusing to users that are familiar with pausing Windows services. This is because we don't implement a service_pause method, only a service_stop method. However, given the way we have to shutdown the service by killing all threads but the current one, pausing the service would have to be implemented the same way. Given the inherently unsafe nature of such an operation, I would not recommend implementing a pause feature. Instead I would recommend not supporting the pause operation on the service itself. Unfortunately, the win32-service gem we use does allow us to opt-out of supporting pausing the service because of this code: ss[:dwControlsAccepted] = SERVICE_ACCEPT_STOP|SERVICE_ACCEPT_SHUTDOWN|SERVICE_ACCEPT_PAUSE_CONTINUE|SERVICE_ACCEPT_SHUTDOWN SERVICE_ACCEPT_PAUSE_CONTINUE should be optional based on what the subclass supports. If we go this route, we should submit a PR to the upstream gem, patch or update the gem in puppet-win32-ruby, and update mcollective's service, if needed, to not support the pause operation. Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.