Jira (PDB-384) PR (825): Don't use global schema validation - cprice404

[gepetto-bot (JIRA)]

Title: Message Title

gepetto-bot commented on an issue   Re: PR (825): Don't use global schema validation - cprice404 cprice404 commented: @kbarber I'm happy to target it at 1.6.x. if you guys prefer. @senior I'm using schema in trapperkeeper now; which means that running PuppetDB in trapperkeeper causes it to behave differently than we intended. This would be a potential issue for any library that you guys ever added a dependency on that happened to use schema. There are also potential performance implications that you could unexpectedly trigger in upstream libraries if you use the global setting, so, in general, it seems like a bad idea to me. Yes, this means that on any functions inside of puppetdb, you would need to think about whether you wanted to enforce validation on every execution, or whether you only needed to do it during testing. This requires a bit more thought, but it's more explicit and I think it's a worthwhile tradeoff. I thought about writing a macro like you suggested, and that seems perfectly reasonable; but I figured I would leave that as something that you guys could decide on without me imposing anything Add Comment   PuppetDB / PDB-384 PR (825): Don't use global schema validation - cprice404 h2. Don't use global schema validation  * Author: Chris Price <>  * Company:  * Github ID: [cprice404|https://github.com/cprice404]  * [Pull Request 825 Discussion|https://github.com/puppetlabs/puppetdb/pull/825]  * [Pull Request 825 File Diff|https://github.com/puppetlabs/puppetdb/pull/825/files] h2. Pull Request Description ---- Prior to this commit... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.