Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank

[gepetto-bot (JIRA)]

Title: Message Title

gepetto-bot commented on an issue   Re: PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Sharpie commented: I think this is good to go. Thanks a bunch for all the work you have put into this patch Felix! Some notes for functional review: The aim of this patch is to provide a functioning `instances` method for the Cron type. This is done by auto-generating names for Puppet resources that get created to represent unmanaged entries in the crontab that were not created by Puppet. Consider a crontab with any entry that is preceded by a `# Puppet Name: ` comment: ``` HEADER: This file was autogenerated at Wed Feb 05 19:59:45 +0000 2014 by puppet. HEADER: While it can still be managed manually, it is definitely not recommended. HEADER: Note particularly that the comments starting with 'Puppet Name' should HEADER: not be deleted, as doing so could cause duplicate cron jobs. Puppet Name: cron-test * * * * /usr/bin/true ``` Currently, Puppet can generate a named resource for this entry because it recognizes the comment. This means that the RAL `puppet resource cron` can return instances and auto-purging can be invoked: ``` puppet resource cron cron { 'cron-test': ensure => 'present', command => '/usr/bin/true', target => 'root', user => 'root', } puppet apply -e 'resources {"cron": purge => true} ' Notice: Compiled catalog for os-head-centos.puppetdebug.vlan in environment production in 0.02 seconds Notice: /Stage[main]/Main/Cron[cron-test]/ensure: removed Notice: Finished catalog run in 0.09 seconds ``` Now, let's add single entry to the crontab that is not preceded by `# Puppet Name: `: ``` HEADER: This file was autogenerated at Wed Feb 05 19:59:45 +0000 2014 by puppet. HEADER: While it can still be managed manually, it is definitely not recommended. HEADER: Note particularly that the comments starting with 'Puppet Name' should HEADER: not be deleted, as doing so could cause duplicate cron jobs. Puppet Name: cron-test * * * * /usr/bin/true * * * * /usr/bin/false ``` Puppet can no longer generate named resources for every entry, so any operation that invokes the `instances` method of the Cron type fails: ``` puppet resource cron Error: Could not run: Title or name must be provided puppet apply -e 'resources {"cron": purge => true} ' Notice: Compiled catalog for os-head-centos.puppetdebug.vlan in environment production in 0.02 seconds Error: /Stage[main]/Main/Resources[cron]: Failed to generate additional resources using 'generate': Title or name must be provided Notice: Finished catalog run in 0.08 seconds ``` This patch should fix the failures in the second test case such that the behavior of the first test case is restored. NOTE: This also contains a patch to `transaction/additional_resource_generator` that is present in PR #2060. Add Comment   Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank h2. (#3220) crontab: allow purging unmanaged resources  * Author: <>  * Company:  * Github ID: [ffrank|https://github.com/ffrank]  * [Pull Request 2024 Discussion|https://github.com/puppetlabs/puppet/pull/2024]  * [Pull Request 2024 File Diff|https://github.com/puppetlabs/puppet/pull/2024/files] h2. Pull Request Description ---- This pull was request... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.