Jira (PUP-1629) WIndows 2008r2 fails to load() a file it previously store()d

[Joshua Cooper (JIRA)]

Title: Message Title

Joshua Cooper commented on an issue   Re: WIndows 2008r2 fails to load() a file it previously store()d Kurt Wall I was wrong earlier about us disabling ruby's GC for the entire length of the spec run. What we do know is disable the GC during each test, and then enable it after each test. This gives ruby a chance to perform a GC if it thinks one is needed, but ensures that doesn't happen during the test. I also ran some perf tests for various combinations, and in summary, I think we are already making the best out of a bad situation. First, I tried the current puppet master branch: $ rm -rf .bundle Gemfile.lock $ git rev-parse HEAD cd73c4085e2bcf1613ca360cd3fd42ce45efafbd $ bundle install --path .bundle/gems --without development extra $ time bundle exec rake ci:spec ... Finished in 2 minutes 18.27 seconds 19086 examples, 0 failures, 87 pending real 2m28.227s user 2m9.975s sys 0m23.618s Next I tried adding an explicit GC.start after running each test. Tests took 20x longer to run: $ time bundle exec rake ci:spec Finished in 39 minutes 0.04813 seconds 19086 examples, 0 failures, 87 pending real 39m10.130s user 38m48.834s sys 0m22.791s Next, I commented out all of the GC calls, and just let ruby do its thing. Tests still took nearly 2x longer to run. $ time bundle exec rake ci:spec .... Finished in 4 minutes 43.71 seconds 19086 examples, 0 failures, 87 pending real 4m55.972s user 4m29.785s sys 0m28.977s Given that our tests do perform GC, I am thinking the ~1.4GB virtual memory sizes I'm seeing on windows are due to a memory leak. Someone may be holding onto references (perhaps win32 gems) preventing objects from being reclaimed. Add Comment   Puppet / PUP-1629 WIndows 2008r2 fails to load() a file it previously store()d While running Puppet-Specs-Windows-master on Windows 2008r2, rspec ./spec/unit/util/storage_spec.rb fails thus: {code}   1) Puppet::Util::Storage when storing to the state file should load() the same information that it store()s      Failure/Error: Puppet::Util::Storage.load      RuntimeError:        Got 2 failure(s) while initializing: File[C:/Windo... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.