Jira (PUP-1698) speed up search for type/define by using index

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg created an issue   Puppet / PUP-1698 speed up search for type/define by using index Issue Type: Improvement Assignee: Unassigned Created: 14/Feb/14 10:00 AM Fix Versions: 3.5.0 Priority: Normal Reporter: Henrik Lindberg The lookup of types must take place before the lookup of user defined resource types. This wastes lots of CPU cycles (described in PUP-1592), especially on the agent. An idea for fixing this is to index all of the types at the start of the transaction. This way, the lib search path only needs to be traversed once. All subsequent lookups can quickly determine if there exists a file to load by doing a simple hash lookup. the structure should be: { TYPENAME => [ PATH, PATH] } (the multiple paths just to be complete - the first will always win, but we get it for free with a simple algorithm like this: search_directories(env).collect do |dir| Dir[File.join(dir,'/puppet/type/*.rb')] end.flatten.reduce({}) do |memo,path| n = File.basename(path, '.rb') if memo[n] memo[n] << path else memo[n] = [path] end memo end The work that remains is to find a suitable place to keep this index so it works both on the master and on the agents - the path of execution differs somewhat, and caching seems more difficult on the agent. Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.