Jira (PUP-1568) Error reporting within augeas provider fails

[Adrien Thebo (JIRA)]

Title: Message Title

Adrien Thebo commented on an issue   Re: Error reporting within augeas provider fails Verified on master. On 3.4.3: [root@centos-6 ~]# lsattr /etc/sysconfig/shorewall ----i--------e- /etc/sysconfig/shorewall [root@centos-6 ~]# cat shorewall.pp augeas{'enable_shorewall': context => '/files/etc/sysconfig/shorewall', changes => 'set startup 1', lens => 'Shellvars.lns', incl => '/etc/sysconfig/shorewall', } [root@centos-6 ~]# puppet apply --debug shorewall.pp Warning: Could not retrieve fact fqdn Notice: Compiled catalog for centos-6 in environment production in 0.02 seconds [snip] Debug: Augeas[enable_shorewall](provider=augeas): Opening augeas with root /, lens path , flags 64 Debug: Augeas[enable_shorewall](provider=augeas): Augeas version 1.0.0 is installed Debug: Augeas[enable_shorewall](provider=augeas): Will attempt to save and only run if files changed Debug: Augeas[enable_shorewall](provider=augeas): sending command 'set' with params ["/files/etc/sysconfig/shorewall/startup", "1"] Debug: Augeas[enable_shorewall](provider=augeas): Files changed, should execute Debug: Augeas[enable_shorewall](provider=augeas): sending command 'set' with params ["/files/etc/sysconfig/shorewall/startup", "1"] Debug: Augeas[enable_shorewall](provider=augeas): Closed the augeas connection Error: undefined local variable or method `success' for #<Puppet::Type::Augeas::ProviderAugeas:0xb710fa38> Error: /Stage[main]/Main/Augeas[enable_shorewall]/returns: change from need_to_run to 0 failed: undefined local variable or method `success' for #<Puppet::Type::Augeas::ProviderAugeas:0xb710fa38> Debug: Finishing transaction -611621978 On master: [root@centos-6 ~]# puppet apply --debug shorewall.pp Warning: Could not retrieve fact fqdn Notice: Compiled catalog for centos-6 in environment production in 0.02 seconds [snip] Debug: Augeas[enable_shorewall](provider=augeas): Opening augeas with root /, lens path , flags 64 Debug: Augeas[enable_shorewall](provider=augeas): Augeas version 1.0.0 is installed Debug: Augeas[enable_shorewall](provider=augeas): Will attempt to save and only run if files changed Debug: Augeas[enable_shorewall](provider=augeas): sending command 'set' with params ["/files/etc/sysconfig/shorewall/startup", "1"] Debug: Augeas[enable_shorewall](provider=augeas): Files changed, should execute Debug: Augeas[enable_shorewall](provider=augeas): sending command 'set' with params ["/files/etc/sysconfig/shorewall/startup", "1"] Debug: Augeas[enable_shorewall](provider=augeas): Closed the augeas connection Error: Save failed, see debug Error: /Stage[main]/Main/Augeas[enable_shorewall]/returns: change from need_to_run to 0 failed: Save failed, see debug Debug: Finishing transaction -612234738 Add Comment   Puppet / PUP-1568 Error reporting within augeas provider fails If the augeas provider fails to store a change to a file it's error reporting is broken due to the refactoring that happened in https://github.com/puppetlabs/puppet/commit/000b8fef6a33e5c9f56c0801523de15a0e5bc30b {noformat} # cat foo.pp augeas{'enable_shorewall':   context => '/files/etc/sysconfig/shorewall',   changes => 'set startup 1',   lens ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.