Jira (PUP-1931) mount provider improvement when options property is not specified

[Kylo Ginsberg (JIRA)]

Title: Message Title

Kylo Ginsberg created an issue   Puppet / PUP-1931 mount provider improvement when options property is not specified Issue Type: Improvement Assignee: Unassigned Created: 13/Mar/14 12:24 PM Fix Versions: 3.6.0 Priority: Normal Reporter: Kylo Ginsberg Not specifying options to a mount resource results in an opaque error message because it creates a bogus fstab without an options field. E.g. I create a loop mountable ext2 filsystem on a CentOS 6 VM and verified that error message when not specifying options and that it goes away if you do specify (correct) options: [root@qolo808yryboag9 puppet]# bundle exec puppet apply -e 'mount { "/mnt/loop": ensure => "mounted", fstype => "ext2", device => "/root/1m" } ' Notice: Compiled catalog for qolo808yryboag9.delivery.puppetlabs.net in environment production in 0.07 seconds Notice: /Stage[main]//Mount[/mnt/loop]/ensure: ensure changed 'unmounted' to 'mounted' Error: /Stage[main]//Mount[/mnt/loop]: Could not evaluate: Execution of '/bin/mount /mnt/loop' returned 32: mount: /root/1m is not a block device (maybe try `-o loop'?) Notice: Finished catalog run in 0.10 seconds vs [root@qolo808yryboag9 puppet]# bundle exec puppet apply -e 'mount { "/mnt/loop": ensure => "mounted", fstype => "ext2", device => "/root/1m", options => "loop,sync,noatime" } ' Notice: Compiled catalog for qolo808yryboag9.delivery.puppetlabs.net in environment production in 0.06 seconds Notice: /Stage[main]//Mount[/mnt/loop]/ensure: ensure changed 'unmounted' to 'mounted' Notice: /Stage[main]//Mount[/mnt/loop]: Triggered 'refresh' from 1 events Notice: Finished catalog run in 0.09 seconds We could improve this by generating a more indicative error message and not adding the bogus fstab entry. 2) error out rather than creating Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.