Jira (PUP-1895) EPP - Define parameters with <% |$x| %> instead of <% ($x) %>

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on an issue   Re: EPP - Define parameters with <% |$x| %> instead of <% ($x) %> The remaining issue is actually validating no-ops. i.e. if a ($x) is followed by a render/string/_expression_ the ($x) (or any similar _expression_ such as just a literal, addition etc, becomes a no-op and can be flagged as at least a warning. (This kind of validation is however both somewhat slow and not perfectly accurate since we have to treat all function calls as having side effects). The no-ops validation is a general issue, not just for EPP. The syntax <% |$x, $y| %> allows for the setup to continue after the last pipe. If <%| and |%> becomes EPP tokens, that will not work, and users have to have to opening set of tags to do the same. e.g. <%-|$x,$y| $product = $x * $y -%> ... vs. <%| $x,$y |%><%-$product = $x * $y -%> ... So, yeah - I don't know, you would have to know how it works in both/all cases since there is no precedent in ERB. What would make the most sense from a Puppet Programming Language perspective would be that the entire file was a lambda and that it started with a brace, and ended with a brace - but that is just painful (i.e. having to always end the file with a right brace). e.g. <%-|$x,$y| { $product = $x * $y -%> ... <%- } -%> Add Comment   Puppet / PUP-1895 EPP - Define parameters with <% |$x| %> instead of <% ($x) %> Since the parameter syntax for lambdas is {noformat} |$x| { ... } {noformat} it seems like the parameters for EPP templates should follow the same style. That would mean that they are {noformat} inline_epp('<% |$x| %>', { x => 1 }) {noformat} instead of {noformat} inline_epp('<% ($x) %>', { x => 1 }) {noformat} This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.