Jira (PUP-1908) incorrect parsing of range after DST change

[Charlie Sharpsteen (JIRA)]

Title: Message Title

Charlie Sharpsteen commented on an issue   Re: incorrect parsing of range after DST change I'm pretty sure the issue stems from this bit of code that compares the declared schedule against the current time: time = Time.local(*ary) unless time.hour == range[0] self.devfail( "Incorrectly converted time: #{time}: #{time.hour} vs #{range[0]}" ) end The problem is, for daylight savings systems that jump forward in the spring at 2 AM: the entire hour between 2:00 AM and 2:59 AM does not exist. So, a local time schedule that includes 2 AM is not valid every day of the year. This would match the error message being thrown: err: Could not apply complete catalog: Incorrectly converted time: Sun Mar 09 03:00:23 -0700 2008: 3 vs 2 at /etc/puppet/manifests/schedules/daily2am.pp:6 From the schedule definition, Puppet was expecting 2 AM, but the call to Time.local returned 3 AM. Some possible workarounds or fixes: Re-write the schedule type to perform calculations in UTC instead of whatever localtime the server is set to. Configure your servers to use UTC as the local time zone. Only use schedules that contain temporal endpoints that exist for every day in your chosen timezone. I'm not sure how much work it would take to migrate schedules to a UTC representation. If someone wants to look into it, we would be happy to review a pull request! Add Comment   Puppet / PUP-1908 incorrect parsing of range after DST change After the Daylight Savings Time change this morning, range statements are not being parsed correctly. The code: <pre> schedule { 'daily2am':     range => "02:00 - 02:59",     period => daily,     repeat => 1, } </pre> Worked just fine for the last few months. After the DST change, this error is generated: <pre> err: Could not apply compl... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.