Jira (PUP-1967) parameter defaults of false and {} does not work

[Charlie Sharpsteen (JIRA)]

Title: Message Title

Charlie Sharpsteen commented on an issue   Re: parameter defaults of false and {} does not work This is pretty trivial to fix: diff --git a/lib/puppet/type.rb b/lib/puppet/type.rb index f382f30..fd1f471 100644 --- a/lib/puppet/type.rb +++ b/lib/puppet/type.rb @@ -813,8 +813,8 @@ class Type return unless parameter = newattr(klass.name) - if value = parameter.default and ! value.nil? - parameter.value = value + if !parameter.default.nil? + parameter.value = parameter.default else @parameters.delete(parameter.name) end However, this simple change causes 20 spec failures in the Augeas, Computer and Cron types. Also, the Types have evolved some interesting ways of working around this issue. Many use the symbols :true and :false instead of booleans. Some times, such as File, have parameters that use both symbols and booleans. So, the root fix is simple but there is a lot of cleanup to be done. Add Comment   Puppet / PUP-1967 parameter defaults of false and {} does not work In a type I have: {code} newparam(:arguments) do    desc "The arguments to send to the action"       defaultto {} end {code} If I do not set the property and check in my provider the value would be nil instead of {}. If instead of defaulting to {} I default to [] then the correct empty array gets to the provider. Similarly defaulting to fa... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.