Jira (PUP-2158) Directory Environments breaks many classic Config File Environments

[John Bollinger (JIRA)]

Title: Message Title

John Bollinger commented on an issue   Re: Directory Environments breaks many classic Config File Environments And I'm looking at changing the switch now to simply exclude or include the directory environment loaders based on the environmentpath setting, so that the underlying old environment behavior would always be there, but directory environments could be switched on in configuration. That sounds not only wiser but also easier to me. Do you even need to go that far, though? Consider the behavior if the default is an empty environment path, and no environment path has explicitly been configured. A search for a directory environment must always fail (quickly) because there are no base directories in the path to check. Per the docs, environment lookup then falls back on dynamic environments, so the result is the same as if the directory environment code is never consulted at all. Unless the environment resolution has other bugs, there should literally be no need for any change vs. 3.5.0 except the default value of the environment path. (And appropriate tests.) There is still the potential for overlapping configuration between dynamic/directory environments, but one would have to explicitly configure that in this case. Yes, but I don't see any way to avoid that and still provide the documented behavior. Add Comment   Puppet / PUP-2158 Directory Environments breaks many classic Config File Environments If you use the script in the classic blog post http://puppetlabs.com/blog/git-workflow-and-puppet-environments you have Config File Environments located at /etc/puppet/environments. Unfortunately, Puppet 3.5.0 will treat them as Directory Environments. If you have a modulepath such as this: {noformat}   modulepath=/etc/puppet/environments/$environme... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.