Jira (PUP-1070) puppetd doesn't always cleanup lockfile properly

[Charlie Sharpsteen (JIRA)]

Title: Message Title

Charlie Sharpsteen commented on an issue   Re: puppetd doesn't always cleanup lockfile properly Seems like the issue is with empty or malformed pidlocks getting left behind. The fix would probably be easy, just remove the following check from the clear_if_stale method: return if lock_pid.nil? Kylo Ginsberg: We recently did this for JSON lockfiles in 94122e9, any reason for not cleaning up malformed pidlocks as well? Add Comment   Puppet / PUP-1070 puppetd doesn't always cleanup lockfile properly ok I had the patch #2661 now running for some weeks and I had nearly no problems anymore. However from time to time (maybe once,twice a week) a random client doesn't remove its lockfile (@/var/lib/puppet/state/puppetdlock@), hence future runs fail. I assume this might still happen due to a uncatched exception (as in #2261), however the problem is a) hard ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.