Jira (PUP-2289) Puppet will purge the /etc/host if it has some invalid lines

[liucy (JIRA)]

Title: Message Title

liucy created an issue   Puppet / PUP-2289 Puppet will purge the /etc/host if it has some invalid lines Issue Type: Bug Affects Versions: 3.4.3 Assignee: Kylo Ginsberg Components: Types and Providers Created: 16/Apr/14 7:38 PM Environment: Centos 6.5 x86_64 Linux puppet.liucy.org 2.6.32-431.11.2.el6.x86_64 #1 SMP Tue Mar 25 19:59:55 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux ruby 1.8.7 (2011-06-30 patchlevel 352) [x86_64-linux] Puppet 3.4.3 Priority: Normal Reporter: liucy normally, i use puppet resource host puppet ip=xxx.xxx.xxx.xxx can add/set a domain name resolution into /etc/hosts. like this: Unable to find source-code formatter for language: shell. Available languages are: actionscript, html, java, _javascript_, none, sql, xhtml, xml [root@puppet ~]# cat /etc/hosts 127.0.0.1 localhost localhost.localdomain localhost4 localhost4.localdomain4 ::1 localhost localhost.localdomain localhost6 localhost6.localdomain6 [root@puppet ~]# puppet resource host puppet ip=172.16.94.128 Notice: /Host[puppet]/ensure: created host { 'puppet': ensure => 'present', ip => '172.16.94.128', target => '/etc/hosts', } [root@puppet ~]# cat /etc/hosts # HEADER: This file was autogenerated at Wed Apr 16 17:57:19 +0800 2014 # HEADER: by puppet. While it can still be managed manually, it # HEADER: is definitely not recommended. 127.0.0.1 localhost localhost.localdomain localhost4 localhost4.localdomain4 ::1 localhost localhost.localdomain localhost6 localhost6.localdomain6 172.16.94.128 puppet but if there have some invalid text in /etc/hosts, link '=' or ', ,', puppet will purge that file and create a new one. Unable to find source-code formatter for language: shell. Available languages are: actionscript, html, java, _javascript_, none, sql, xhtml, xml [root@puppet ~]# cat /etc/hosts # HEADER: This file was autogenerated at Wed Apr 16 17:57:19 +0800 2014 # HEADER: by puppet. While it can still be managed manually, it # HEADER: is definitely not recommended. 127.0.0.1 localhost localhost.localdomain localhost4 localhost4.localdomain4 ::1 localhost localhost.localdomain localhost6 localhost6.localdomain6 == [root@puppet ~]# puppet resource host puppet ip=172.16.94.128 Error: Could not prefetch host provider 'parsed': Could not parse line "==" at /etc/hosts:4 Notice: /Host[puppet]/ensure: created host { 'puppet': ensure => 'present', ip => '172.16.94.128', target => '/etc/hosts', } [root@puppet ~]# cat /etc/hosts # HEADER: This file was autogenerated at Wed Apr 16 18:00:59 +0800 2014 # HEADER: by puppet. While it can still be managed manually, it # HEADER: is definitely not recommended. 172.16.94.128 puppet i checked the source code, it have three rules to check if the lines in /etc/hosts invalid. /^#/ /^\s*$/ /^(\S+)\s+(\S+)\s*(.?)?(?:\s#\s*(.*))?$/ but i think if puppet checked there is some invalid lines, it should report error and exit, not keep going and purge my hosts file Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.