Jira (PUP-2080) Support functions written in pp

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on an issue   Re: Support functions written in pp It really should be a QualifiedName if it should behave the same way as if :FUNCTION was not a token. I.e, like this: Function : FUNCTION { result = Factory.QNAME(val[0][:value]) ; loc result, val[0] } We can use that method when we know the string is not a number. The 'literal' method produces LiteralStringExpression (i.e. 'function') when given a string. A bare word (that is not an upper case word) produces a QualifiedName (what QNAME factory method produces). It is the evaluator that turns bare words (i.e. QualifiedName) into a String. It would otherwise not be possible to differentiate between: "foo"() # illegal foo() # legal, call foo However , by making it a literal string, we block it from being used as a name, and thus no one can use it as the name of a class, or define, or call a function called 'function'. In a way that reserves it, but people may still need to change their logic later - i.e. $a = function will be a syntax error. Options: keep it the way you change it change it to emit a QualitifedName (i.e. call QNAME instead of literal) add back FunctionDefinition, and create it, but without any content except the name, then validate it as reserved (this means also adding back a label and a dumper for it, and it is possible to test that it is reserved). add a general ReservedWordExpression, and validate that I think option 3 is the best if we want it to not be transparent, option 2 otherwise. Add Comment   Puppet / PUP-2080 Support functions written in pp Add the ability to write functions in the puppet language. Functions should be stored under ./functions relative to the root of a module. Function names should support fully qualified names. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.