Jira (PUP-2427) Pluginsync will download every file every time if digest_algorithms do not agree

[Joshua Cooper (JIRA)]

Title: Message Title

Joshua Cooper created an issue   Puppet / PUP-2427 Pluginsync will download every file every time if digest_algorithms do not agree Issue Type: Bug Affects Versions: 3.6.0 Assignee: Unassigned Created: 01/May/14 4:39 PM Priority: Normal Reporter: Joshua Cooper Due to PUP-1840 , if agent and master do not agree on digest_algorithm, e.g. agent is using md5, server is using sha256, then the agent will make a file_metadata request without specifying which checksum type it expects. The file serving code will calculate the checksum of the file based on how the master is currently configured, and not the checksum that the client accepts. Since current != desired, puppet will re-download the file (for every pluginsync'ed file, every time the agent runs): Notice: /File[/Users/josh/.puppet/var/lib/facter/pe_version.rb]/content: content changed '{md5}4a9353952963b011759f3e6652a10da5' to '{sha256}27498d481b63291c84537447ce5d0545a3406a458321a25324e7040fd163013d' The problem is that the master needs to handle checksum types like it does serialization formats. The master should have a "preferred_digest_algorithm" setting that accepts multiple values, e.g. sha256, sha1, but not md5. Then the client needs to send the checksum it accepts in the file_metadata request. The file serving code needs to validate the checksum from the request, and generate the metadata based on the requested checksum. Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.