Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format

[Hunter Haugen (JIRA)]

Title: Message Title

Hunter Haugen commented on an issue   Re: `puppet module build` should use `metadata.json` as input format When using ea39a3de5705020d79ae89d6ab513b37fa662ce7 With Modulefile and metadata.json: Maybe success? It appears to work as specified, preferring the contents of the metadata.json and ignoring the Modulefile, but this is backwards incompatible as it previously would merge the two (eg, if there are dependencies declared in Modulefile but not in metadata.json, then the package will have no dependencies whereas before it WOULD have dependencies). This seems to be intended though. With Modulefile but no metadata.json: Success. It works as described. With no Modulefile but with metadata.json: Success. This was not previously supported so is not backwards-incompatible, and works as described. When using current master (90aad3fff7d270ef2683f486cdf999c003510cf0): With Modulefile and metadata.json: Same as above. With Modulefile but no metadata.json: Fail? The dependency list that appears in the repo Modulefile specifies two dependencies, but the package metadata.json appears like this: "dependencies": [ "#<Puppet::ModuleTool::Dependency:0x007fc7c4218f48>", "#<Puppet::ModuleTool::Dependency:0x007fc7c4218ac0>" ] Perhaps this is on purpose, if master branch no longer supports Modulefile With no Modulefile but with metadata.json: Same as above. Other notes: I am seeing /Users/hunner/Documents/work/git/puppet/lib/puppet/version.rb:10: warning: already initialized constant PUPPETVERSION, but I see this on 3.5.1 as well. Add Comment   Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format `puppet module build` This action is most impacted by this change though we will maintain compatibility with users still using Modulefile as their input format. Here's how that will work when a user initiates build. - If the user provides a Modulefile at the root of their module, PMT will use it exclusively to build the release and issue a deprecati... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.