Jira (FACT-481) Infinite loop if EC2 metadata server times out

Dominic Cleal (JIRA) Thu, 08 May 2014 03:59:28 -0700

Title: Message Title

Dominic Cleal created an issue

FACT-481

Issue Type:	Bug
Affects Versions:	2.0.2
Assignee:	Dominic Cleal
Created:	08/May/14 3:57 AM
Environment:	Facter 'stable' branch (unreleased 2.0.2) Xen system (where 'virtual' =~ /xen/) Inaccessible metadata server (with timeouts) Seen on Rackspace Cloud
Priority:	Critical
Reporter:	Dominic Cleal

On a Rackspace VM, Facter gets into an infinite loop when trying to contact the EC2 metadata server. The retry loop in lib/facter/ec2/rest.rb doesn't increment the counter on each iteration. This causes the Puppet agent to permanently hang.

To reproduce on a non-Rackspace system, just run:
FACTER_virtual=xen bin/facter

(Assuming there's no metadata server available at 169.254.169.254. Change the loop to sleep instead if so.)

The command will just hang, and the backtrace if cancelled will show:

                                                    $ FACTER_virtual=xen bin/facter
^C/home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/net/http.rb:560:in `initialize': Interrupt
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/net/http.rb:560:in `open'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/net/http.rb:560:in `connect'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/timeout.rb:53:in `timeout'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/timeout.rb:101:in `timeout'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/net/http.rb:560:in `connect'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/net/http.rb:553:in `do_start'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/net/http.rb:542:in `start'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/open-uri.rb:242:in `open_http'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/open-uri.rb:616:in `buffer_open'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/open-uri.rb:164:in `open_loop'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/open-uri.rb:162:in `catch'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/open-uri.rb:162:in `open_loop'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/open-uri.rb:132:in `open_uri'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/open-uri.rb:518:in `open'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/open-uri.rb:30:in `open'
	from /home/dcleal/code/facter/facter/lib/facter/ec2/rest.rb:24:in `reachable?'
	from /home/dcleal/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/timeout.rb:67:in `timeout'
	from /home/dcleal/code/facter/facter/lib/facter/ec2/rest.rb:23:in `reachable?'
	from /home/dcleal/code/facter/facter/lib/facter/ec2.rb:11
	from /home/dcleal/code/facter/facter/lib/facter/util/confine.rb:40:in `call'
	from /home/dcleal/code/facter/facter/lib/facter/util/confine.rb:40:in `true?'
	from /home/dcleal/code/facter/facter/lib/facter/core/suitable.rb:111:in `suitable?'

                                                

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (FACT-481) Infinite loop if EC2 metadata server times out

Reply via email to