Jira (PUP-2713) directoryservice provider has fragile version check

[Clay Caviness (JIRA)]

Title: Message Title

Clay Caviness created an issue   Puppet / PUP-2713 directoryservice provider has fragile version check Issue Type: Bug Affects Versions: 3.5.1 Assignee: Kylo Ginsberg Components: Types and Providers Created: 02/Jun/14 1:53 PM Priority: Normal Reporter: Clay Caviness The OS X directoryservice nameservice provider has a very fragile version check. def self.fail_if_wrong_version fail("Puppet does not support OS X versions < 10.5") unless self.get_macosx_version_major >= "10.5" end If the major version were to ever be, say, 10.10, this will fail quite nicely. The code should be updated to use something like: fail() unless Gem::Version.new(self.get_macosx_version_major) >= Gem::Version.new('10.5') Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.