Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

Adrien Thebo (JIRA) Mon, 02 Jun 2014 14:58:22 -0700

Title: Message Title

Adrien Thebo commented on an issue

This issue is two fold - Facter is inconsistent in how it handles threading, and Ruby's `Thread.exclusive` uses a single lock instead of a lock per critical region:

                                                    [3] pry(main)> Thread.exclusive do
[3] pry(main)*   Thread.exclusive do
[3] pry(main)*     puts "hi"
[3] pry(main)*   end  
[3] pry(main)* end
ThreadError: deadlock; recursive locking
from <internal:prelude>:8:in `lock' 

                                                

Mcollective itself uses `Thread.exclusive` when retrieving facts (https://github.com/puppetlabs/marionette-collective/blob/master/lib/mcollective/facts/base.rb#L27) and when Facter itself tries to acquire a lock before the WMI query, we get a deadlock. The WMI query itself should be reentrant so we can remove the threading code from facter.

This is only an issue with the facter-facts mcollective facts plugin (https://github.com/puppetlabs/mcollective-facter-facts/blob/master/facts/facter_facts.rb) and we use the yaml facts plugin in mcollective.

Add Comment

Facter /

FACT-482

The use of facter facts plugin for mcollective causes the following error on MS Windows only:

in `rescue in block in get_fact' Failed to load facts: ThreadError: deadlock; recursive locking

This setup works very well on *nix operating systems though. Can the code at lib/facter/processor.rb:120 with "Thread::exclusive do" be refactored to allow such ...

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

Reply via email to