Jira (PUP-1931) mount provider improvement when options property is not specified

[Mark Bainter (JIRA)]

Title: Message Title

Mark Bainter commented on an issue   Re: mount provider improvement when options property is not specified I did some work on this but I'm not sure of the best path forward, so some feedback would be welcome. It is easy enough to detect in the provider when (as in the example) a device is not actually a block device, and then verify that "loop" is set. However, there are exceptions where this might be the case (such as using a swapfile) so there is a somewhat open-ended list of exceptions that might need to be handled on that approach. It seems to me like the larger concern here is that the "options" field is empty and the fstab is updated prior to mount, so when the mount fails there's no rollback. We could add options to the "required" list, but that would be a significant change for existing use, and would result in a lot of needless data entry. It seems to me that a standard default for the Linux platform of 'defaults' would do the trick here. So I propose the following change: Mount Type Changes diff --git a/lib/puppet/type/mount.rb b/lib/puppet/type/mount.rb index 8111a0d..74f2e9d 100644 --- a/lib/puppet/type/mount.rb +++ b/lib/puppet/type/mount.rb @@ -171,6 +171,14 @@ module Puppet desc "Mount options for the mounts, as they would appear in the fstab." + defaultto do + if Facter.value(:kernel) == 'Linux' + 'defaults' + else + nil + end + end + validate do |value| raise Puppet::Error, "option must not contain whitespace: #{value}" if value =~ /\s/ end With this patch in place, the error still occurs: ... Error: /Stage[main]/Main/Mount[/mnt/loop]: Could not evaluate: Execution of '/bin/mount /mnt/loop' returned 32: mount: /root/1m is not a block device (maybe try `-o loop'?) ... but the fstab file is correct: ... proc /proc proc defaults 0 0 /root/1m /mnt/loop ext2 defaults 0 0 Since this only partially addresses the originally reported issue, I'd appreciate some feedback on this proposed solution. Add Comment   Puppet / PUP-1931 mount provider improvement when options property is not specified Not specifying options to a mount resource results in an opaque error message because it creates a bogus fstab without an options field. E.g. I create a loop mountable ext2 filsystem on a CentOS 6 VM and verified that error message when not specifying {{options}} and that it goes away if you do specify (correct) {{options}}: {code} [root@qolo808yry... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.