Jira (PUP-2394) freeze_main does not work as expected.

Henrik Lindberg (JIRA) Mon, 09 Jun 2014 06:57:06 -0700

Title: Message Title

Henrik Lindberg commented on an issue

The test that checks if merged code adds logic to the main class body is flawed because it does not analyze the code block that it is trying to merge for the purpose of detecting if it contains anything that will merge code.

Assuming that freeze_main once worked as expected, this is a regression that is probably created by parser returning an AST::BlockExpression in the "" namespace at all times rather than sometimes returning a single class, and sometimes a block. (The freeze main would then have failed if there was an attempt to initialize more than one thing in the same file).

To correct this, the method Puppet::Resource::Type#merge should perform a more elaborate check, alternatively delegate the mutation check
to the Puppet::Parser::ParserFactory.code_merger.concatenate method which is responsible for the actual concatenation and thus is already iterating over the data for the purpose of mutating the structure.

To replicate the issue simply do:

                                                    include(test::test)

                                                

and have a module with that class

                                                    class test::test {
  notice 'in test::test class'
}

                                                

Add Comment

Puppet /

PUP-2394

Initially, i thought that this was an issue with hiera_include but it turns out that freeze_main is not working as I expect.

To the best of my knowledge, 'include' statements should work with freeze_main enabled, but they don't seem to be in the test case provided in PUP-2391 which has been linked to this issue.

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-2394) freeze_main does not work as expected.

Reply via email to