Jira (PUP-837) FFI Puppet::Util::Windows::SID module

[Kurt Wall (JIRA)]

Title: Message Title

Kurt Wall commented on an issue   Re: FFI Puppet::Util::Windows::SID module Can this be resolved Josh Cooper? Not much review I can do here anyhow. Add Comment   Puppet / PUP-837 FFI Puppet::Util::Windows::SID module Use FFI to define and invoke Windows APIs. Always call the wide-version, where applicable, e.g. ConvertStringSidtoSidW. Also don't do things like: {code}         strncpy(sid_buf, str_ptr.unpack('L')[0], sid_buf.size - 1)         sid_buf[sid_buf.size - 1] = 0.chr         return sid_buf.strip {code} This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.