Jira (PDB-704) PuppetDB installing postgresql is not optional

[Kenneth Barber (JIRA)]

Title: Message Title

Kenneth Barber commented on an issue   Re: PuppetDB installing postgresql is not optional > So you're saying I should divert from the standardised installation of the module to install the standard module. Aaron Hicks I'm saying you should divert from the standardised installation for the database element because your needs aren't standard (well at least not according to the module). So yeah, this is pretty much what I am saying. In this case, the class for helping you install the PuppetDB 'database' is just simply a wrapper around the postgresql::server class, and then it declares a single 'postgresql::server::db' resource to setup the database/user/grant. So, because you've want to declare postgresql::server outside of this module, I'm simply suggesting adding something like this to your manifest to complete the same job as 'puppetdb' wrapper: postgresql::server::db { 'puppetdb': user => 'puppetdb', password => 'puppetdb', grant => 'all', } Its simply a case that we would be remiss to try and replicate every single item and possible configuration for PostgreSQL in the PuppetDB module, the work of mapping such a thing is simply a waste and you'll never keep up with the parity match (unless you do horrible things). So in my honest opinion, if you stretch beyond the basic needs of the puppetdb way of doing it, I say go directly to the PostgreSQL module to do the work. And this is perfectly fine IMHO. > We're talking about a fundamental separation of concerns here. Okay. > The PuppetDB module installs PuppetDB, it's not the PostgreSQL module that installs PostgreSQL. That sentence doesn't make sense. In the case of the PuppetDB module, it does use the postgresql module to install postgresql. Even in your example you use the postgresql module to install postgresql. Perhaps I'm not understanding your message here. > Using resources (like databases, grants, roles etc.) is fine and has no impact on other modules or services (unless there are other instances of the resource with exactly the same name). Declaring classes prohibits declaring that class in different ways if that class is overloaded (say when a database server provides services for several databases), unless you're prepared to expose and pass through all that classes parameters (like the PuppetDB module does for listen_addresses). Yes, everything you have said is true. I'm sensing you're trying to express a puritist concern here, but I'm not getting it . I'm trying to help you with your issue, but I think you want to debate the architecture more than any bug perhaps? Add Comment   PuppetDB / PDB-704 PuppetDB installing postgresql is not optional The puppetlabs-puppetdb module installs PostgreSQL, and this is not optional. This means it is not possible to install postgresql separately with a tuned configuration for your environment, or in a manner that could be reused by other services. Either make the installation of the PuppetDB optiona via a parameter, or remove it completely. By param... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.