Jira (PUP-1044) FileBucket should not keep files in memory

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on an issue   Re: FileBucket should not keep files in memory The unwanted behavior seems to be in Puppet::FileBucket::Dipper and in FileBucket::File. The dipper reads the entire contents from files using binread, and asks for the content from a FileBucket::File as a String. The checksum calculation can be made on a file instead of content, by calling a checksum method with _file appended instead of just the method named after the type of checksum. The Puppet::Util::Checksums performs efficient checksum calculation by reading 4096 byte sized chunks. (That could also be optimized to read the file system's most optimal size which is its disk buffer size (which often is 2x4096) - with a system that uses 1x4096 blocks there is very little speed improvement using 2x4096, but it makes a difference for those that do use 2x4096). Add Comment   Puppet / PUP-1044 FileBucket should not keep files in memory It should not be necessary to load entire files into memory to checksum them. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.