Jira (PUP-1066) yum repos should be ensurable.

[Adrien Thebo (JIRA)]

Title: Message Title

Adrien Thebo commented on an issue   Re: yum repos should be ensurable. If a .repo file is corrupted in the manner that you're demonstrating, it cannot be parsed in any situation. If the parser hits invalid data it cannot continue and it's impossible to determine if there are valid repos following the corrupted data, so unparsable files cannot be removed safely. With respect to files that no longer have any yumrepo resources defined, the files may still have content that users created. Comments in yumrepo files are unmanaged and while implementing the ensurable behavior I opted to take the less destructive path and leave those contents alone. When rewriting the inifile code I built in the capacity to remove files that no longer have managed sections in the given file (https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/inifile.rb#L118-L121) but chose to defer the decision in order to ship the ensurable functionality sooner rather than later. If you think that files without defined resources should be removed, please file a new issue for that. In the mean time, if you purge all unmanaged yumrepo sections, the sections themselves will be entirely removed so this ticket itself is complete. In addition if you believe you have found a regression with the `reposdir` section not being respected, please file a new bug documenting that regression with steps to reproduce. Add Comment   Puppet / PUP-1066 yum repos should be ensurable. This should be done so that we can solve:  #949 - yumrepo should support removal of repository  #1023 - yumrepo option to purge unmanaged repos This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.