Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer

[Ethan Brown (JIRA)]

Title: Message Title

Ethan Brown commented on an issue   Re: Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer All PR comments addressed. Switched to block form across the board, and added cleanup to our FFI methods that return pointers that must be freed. In new methods accepting blocks, always assume one is given (i.e. don't bother complicating the code by using block_given? to force callers to use block and free memory) In cases where there are yields, and unmanaged memory is only available inside the yield, methods have been updated to return nil (needed especially in cases where the method would otherwise return the result of CloseHandle for instance). Found a number of subtle bugs around values returned from inside blocks. Tried to enforce proper memory usage semantics, and capturing values inside blocks using closures. In recent tests under memory pressue, I no longer get failures in IsValidAcl ... actually receive NoMemoryError, which I believe is an improvement. 23) Puppet::Type::Package Puppet::Type::Package Puppet::Type::Package when it should be absent should uninstall if it is latest Failure/Error: Unable to find matching line from backtrace NoMemoryError: failed to allocate memory # ./lib/puppet/defaults.rb:1611:in `block in <module:Puppet>' # ./lib/puppet/settings.rb:333:in `block in call_hooks_deferred_to_application_initialization' # ./lib/puppet/settings.rb:331:in `each' # ./lib/puppet/settings.rb:331:in `call_hooks_deferred_to_application_initialization' # ./lib/puppet/settings.rb:324:in `initialize_app_defaults' # ./lib/puppet/test/test_helper.rb:212:in `initialize_settings_before_each' # ./lib/puppet/test/test_helper.rb:121:in `before_each_test' Add Comment   Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer As of the merge for PUP-2657, we've noticed some intermittent test failures (in both CI and locally) in semi-random locations. The merge commit is as follows: https://github.com/puppetlabs/puppet/commit/d38153bd712167e2777bdd4c63d37e2e8d1cdb39 The commit itself has been reviewed and it doesn't seem to have issues itself, but it's likely it's trigge... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.