Jira (PUP-2511) Add parser function digest: uses digest_algorithm to hash, not strictly md5

[Andy Parker (JIRA)]

Title: Message Title

Andy Parker commented on an issue   Re: Add parser function digest: uses digest_algorithm to hash, not strictly md5 Confirmed that it calculates the checksums correctly: [09:43:56][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > echo "hi" | shasum -a 256 98ea6e4f216f2fb4b69fff9b3a44842c38686ca685f3f55dc48c5d3fb1107be4 - [09:44:05][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > man shasum [09:44:38][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > echo -n "hi" | shasum -a 256 8f434346648f6b96df89dda901c5176b10a6d83961dd3c1ac88b59b2dc327aa4 - 1 require 'puppet/util/checksums' [09:44:43][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > echo -n "hi" | md5 49f68a5c8493ec2c0bf489821c21fc3b [09:44:54][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > be puppet apply -e 'notice(digest("hi"))' --digest_algorithm md5 Notice: Scope(Class[main]): 49f68a5c8493ec2c0bf489821c21fc3b Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.02 seconds Notice: Finished catalog run in 0.04 seconds [09:45:05][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > be puppet apply -e 'notice(digest("hi"))' --digest_algorithm sha256 Notice: Scope(Class[main]): 8f434346648f6b96df89dda901c5176b10a6d83961dd3c1ac88b59b2dc327aa4 Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.02 seconds Notice: Finished catalog run in 0.04 seconds And also confirmed that it errors in several expected situations: > be puppet apply -e 'notice(digest("hi", "nope"))' --digest_algorithm sha256 Error: digest(): Wrong number of arguments given (2 for 1) at line 1 on node aparker.corp.puppetlabs.net Wrapped exception: digest(): Wrong number of arguments given (2 for 1) Error: digest(): Wrong number of arguments given (2 for 1) at line 1 on node aparker.corp.puppetlabs.net [09:45:26][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > be puppet apply -e 'notice(digest())' --digest_algorithm sha256 Error: digest(): Wrong number of arguments given (0 for 1) at line 1 on node aparker.corp.puppetlabs.net Wrapped exception: digest(): Wrong number of arguments given (0 for 1) Error: digest(): Wrong number of arguments given (0 for 1) at line 1 on node aparker.corp.puppetlabs.net [09:45:36][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > be puppet apply -e 'digest("hi")' --digest_algorithm sha256 Error: Function 'digest' must be the value of a statement at line 1 on node aparker.corp.puppetlabs.net Error: Function 'digest' must be the value of a statement at line 1 on node aparker.corp.puppetlabs.net [09:45:49][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet However, it doesn't reliably error when given something that isn't a string: > be puppet apply -e 'notice(digest(1))' --digest_algorithm sha256 Notice: Scope(Class[main]): 6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.02 seconds Notice: Finished catalog run in 0.05 seconds [09:46:02][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > be puppet apply -e 'notice(digest([1, 2, 3]))' --digest_algorithm sha256 Error: can't convert Array into String at line 1 on node aparker.corp.puppetlabs.net Wrapped exception: can't convert Array into String Error: can't convert Array into String at line 1 on node aparker.corp.puppetlabs.net [09:46:10][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > be puppet apply -e 'notice(digest(Hi))' --digest_algorithm sha256 Notice: Scope(Class[main]): 3639efcd08abb273b1619e82e78c29a7df02c1051b1820e99fc395dcaa3326b8 Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.01 seconds Notice: Finished catalog run in 0.05 seconds I would have expected that the value 1 would have failed because it is a number. However, it doesn't because under the current parser 1 is actually a string. This then uncovered some behavior differences between the current and future parsers with the function: [09:46:43][Ruby(ruby-1.9.3-p484)][Git(master)] andy:puppet > be puppet apply -e 'notice(digest(Hi))' --digest_algorithm sha256 --parser future Error: Evaluation Error: Error while evaluating a Function Call, can't convert Puppet::Resource into String at line 1:8 on node aparker.corp.puppetlabs.net Error: Evaluation Error: Error while evaluating a Function Call, can't convert Puppet::Resource into String at line 1:8 on node aparker.corp.puppetlabs.net I tried adding a check that the argument is a string, but because Hi and 1 are actually strings under the current parser, this didn't resolve the differences. Add Comment   Puppet / PUP-2511 Add parser function digest: uses digest_algorithm to hash, not strictly md5 Puppet has an md5 parser function, which returns the MD5 digest of its argument. On hosts configured for compliance with U.S. Federal Information Processing Standard (FIPS) 140-2, attempts to use the MD5 algorithm cause errors, because MD5 is no longer FIPS Approved. This patch adds a parser function called digest, which returns the digest of its arg... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.