Jira (PUP-2755) Move iterative functions to 4x function API

[Charlie Sharpsteen (JIRA)]

Title: Message Title

Charlie Sharpsteen commented on an issue   Re: Move iterative functions to 4x function API I tested the new function implementations against the examples in their docstrings. The implementations of map, slice and with appear to be working as documented. each, filter, map and reduce are showing some differences in behavior. Comparisons were made between commit 0fa8d9e, which represents the code before PR-2765 was merged and commit 8d56057 which represents the code after PR-2765 was merged. All behaviors noticed at commit 8d56057 have been re-produced using the current HEAD as of this writing: bf5ad07. I think the issues I've noticed can be summarized as: Iteration blocks for Hashes now yield |numeric index, tuple| instead of |key, value|. The memo argument to reduce is no longer optional. The parser has processing a Hash iteration that follows an Array iteration. Gory details follow. Each Tested the following examples: [1,2,3].each |$val| { notice $val } [5,6,7].each |$index, $val| { notice "($index,$val)" } {a=>1, b=>2, c=>3}.each |$val| { notice $val } {a=>1, b=>2, c=>3}.each |$key, $val| { notice "($key,$val)" } Integer[ 10, 20 ].each |$index, $value| { notice "($index,$value)" } "hello".each |$char| { notice $char } 3.each |$number| { notice $number } Everything checked out, except the examples that operate on hashes. For the |$key, $val| case: # each-hash-key-val.pp {a=>1, b=>2, c=>3}.each |$key, $val| { notice "($key,$val)" } The results are: # Before PR-2765 puppet apply --parser=future each-hash-key-val.pp Notice: (a,1) Notice: (b,2) Notice: (c,3) # After PR-2765, numeric indicies are used and value is an array. puppet apply --parser=future each-hash-key-val.pp Notice: (0,[a, 1]) Notice: (1,[b, 2]) Notice: (2,[c, 3]) Also, when iterating over hashes, there appears to be a parser error. For example iterating over two successive arrays works: [1,2,3].each |$item| { notice $item } "hello".each |$item| { notice $item } Following a hash iteration with an array iteration works: {a=>1, b=>2, c=>3}.each |$item| { notice $item } [1,2,3].each |$item| { notice $item } But following an array iteration with a hash iteration fails: # each-array-hash.pp puppet apply --parser=future each-array-hash.pp Error: Could not parse for environment production: _expression_ is not valid as a resource, resource-default, or resource-override at #<Puppet::Pops::Model::Factory:0x00000002f7a308>:#<Puppet::Pops::Model::Factory:0x00000002f7a9e8>:#<Puppet::Pops::Model::Factory:0x00000002f79cf0> on node wordpress-demo.puppetdebug.vlan Error: Could not parse for environment production: _expression_ is not valid as a resource, resource-default, or resource-override at #<Puppet::Pops::Model::Factory:0x00000002f7a308>:#<Puppet::Pops::Model::Factory:0x00000002f7a9e8>:#<Puppet::Pops::Model::Factory:0x00000002f79cf0> on node wordpress-demo.puppetdebug.vlan This behavior was not introduced by PR-2765 and is present in commit 0fa8d9e. Filter There was a change in the way hashes are filtered using |$key, $value|, for example: # filter-hash.pp # selects all that end with 'berry' and value >= 1 $a = {"raspberry"=>0, "blueberry"=>1, "orange"=>1} notice $a.filter |$key, $x| { $key =~ /berry$/ and $x >= 1 } # blueberry The results are: # Before PR-2765 puppet apply --parser=future filter-hash.pp Notice: {blueberry => 1} # After PR-2765 puppet apply --parser=future filter-hash.pp Error: Evaluation Error: Left match operand must result in a String value. Got an Integer. at /vagrant/PUP-2755/test-future_functions/tests/filter-hash.pp:3:31 on node wordpress-demo.puppetdebug.vlan Error: Evaluation Error: Left match operand must result in a String value. Got an Integer. at /vagrant/PUP-2755/test-future_functions/tests/filter-hash.pp:3:31 on node wordpress-demo.puppetdebug.vlan This may be the same issue noticed with each where |key, value| changed to |numeric index, tuple|. Map Also a change in the way |$key, $value| works with hashes: # map-hash.pp $a = { 'key1' => 'value1', 'key2' => 'value2', } # Turns hash into array of values notice $a.map |$key,$val|{ $val } # Turns hash into array of keys notice $a.map |$key,$val|{ $key } Results: # Before PR-2765 puppet apply --parser=future map-hash.pp Notice: [value1, value2] Notice: [key1, key2] # After PR-2765 puppet apply --parser=future map-hash.pp Notice: [[key1, value1], [key2, value2]] Notice: [0, 1] Reduce No longer works when an initial value is not specified: # reduce-no-init-val.pp notice Integer[1,4].reduce |$memo, $x| { $memo + $x } Results: # Before PR-2765 puppet apply --parser=future reduce-no-init-val.pp Notice: 10 # After PR-2765 puppet apply --parser=future reduce-no-init-val.pp Error: Evaluation Error: Error while evaluating a Method call, function 'reduce' called with mis-matched arguments expected one of: reduce(Any enumerable) - arg count {1} reduce(Any enumerable, Any memo, Callable block) - arg count {3} actual: reduce(Type[Integer], Callable[Any, Any]) - arg count {2} at /vagrant/PUP-2755/test-future_functions/tests/reduce-no-init-val.pp:1:20 on node wordpress-demo.puppetdebug.vlan Error: Evaluation Error: Error while evaluating a Method call, function 'reduce' called with mis-matched arguments expected one of: reduce(Any enumerable) - arg count {1} reduce(Any enumerable, Any memo, Callable block) - arg count {3} actual: reduce(Type[Integer], Callable[Any, Any]) - arg count {2} at /vagrant/PUP-2755/test-future_functions/tests/reduce-no-init-val.pp:1:20 on node wordpress-demo.puppetdebug.vlan Add Comment   Puppet / PUP-2755 Move iterative functions to 4x function API The iterative functions (each, map, filter, reduce, slice) should be moved to the 4x function API. (Currently there is a cheat implemented in the evaluator when these are called to avoid having the arguments transformed to the 3x function API). This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.