Jira (PUP-2808) generate is too safe (false sense security)

[Vinod Purushothaman (JIRA)]

Title: Message Title

Vinod Purushothaman commented on an issue   Re: generate is too safe (false sense security) Hi, define mysql-server::getdb ($bucketname, $filename) { exec { "getdb-$ {name} ": path => '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin/', $dbbackup = generate(“/bin/sh”, “-c”, "/usr/bin/s3cmd ls $ {bucketname} | grep ${bucketname} /$ {bucketname} * | sort -r | head -1 | awk ' {print $4} '"), notify { "Database backup file is $dbbackup": } cwd => '/var/lib/mysql', command => 's3cmd get $ {dbbackup} ' } } I have all mysql backup file in an s3 bucket. I wanna download the latest backup file to one of my node. I define a type which will accept the s3 bucket name and the backup file name. But I am getting few errors, can you guys help me. This is my error : puppet parser validate getdb.pp Error: Could not parse for environment production: Syntax error at 'dbbackup'; expected '}' at /etc/puppet/modules/mysql-server/manifests/getdb.pp:4 Add Comment   Puppet / PUP-2808 generate is too safe (false sense security) Taken from https://projects.puppetlabs.com/issues/5481 (Export to JIRA button didn't work). "The generate[1] function is too safe. We should encourage people to do safe things and perhaps log warnings when they do not, but we should not keep people from running commands that we deem to be unsafe." An example is given that shows it is possible to ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.