Jira (FACT-632) weighted fact not resolved correctly

[Ben Roberts (JIRA)]

Title: Message Title

Ben Roberts created an issue   Facter / FACT-632 weighted fact not resolved correctly Issue Type: Bug Affects Versions: 2.1.0 Assignee: Eric Sorenson Components: Community Created: 27/Jul/14 11:13 AM Environment: Sabayon, puppet=3.6.2, facter=2.1.0 Priority: Normal Reporter: Ben Roberts While trying to override the operatingsystem fact for a gentoo derivative (using the Cumulus Linux example from the facter source code as a template) I've run into an issue where the fact resolves correctly in some situations, but not others. Weighted fact modules/sabayon/lib/facter/operatingsystem.rb Facter.add(:operatingsystem) do # Sabayon Linux is a variant of Gentoo so this resolution needs to come # before the Gentoo resolution. has_weight(100) confine :kernel => :linux puts "MY FACT" setcode do release_info = Facter::Util::Operatingsystem.os_release puts "I am #{release_info['NAME']}" if release_info['NAME'] == "Sabayon" 'Sabayon' end end end facter For example if run as facter -p operatingsystem I get the correct value. If run as facter -p I get the upstream value. Chucking a couple of print statements in I confirm my code is being loaded in both cases, but my resolution only attempted in the first case. triumph ~ # facter -p operatingsystem MY FACT I am Sabayon Sabayon triumph ~ # facter -p | egrep 'FACT|Sabayon|operatingsystem' MY FACT Could not retrieve fact='zpool_version', resolution='<anonymous>': undefined method `captures' for nil:NilClass lsbdistdescription => Sabayon Linux amd64 14.08 lsbdistid => Sabayon operatingsystem => Gentoo operatingsystemrelease => 3.15.0-sabayon triumph ~ # puppet More interestingly, when doing a puppet run (after the fact has been pluginsync'd) I see that the fact is evaluated three times. On the first invocation the overridden code is executed; the subsequent two runs don't execute my override so I end up with the upstream value and hence $::operatingsystem contains the wrong value in my manifests. triumph ~ # puppet agent --test --environment development --tags foo --noop MY FACT I am Sabayon Info: Retrieving pluginfacts Info: Retrieving plugin MY FACT Info: Loading facts in /var/lib/puppet/lib/facter/operatingsystem.rb MY FACT Info: Caching catalog for triumph.jellybean.sihnon.net Info: Applying configuration version '1406483265' ... Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.