Jira (PUP-2898) Long form Resource Type reference fools "future parser" this is an override

[Joshua Partlow (JIRA)]

Title: Message Title

Joshua Partlow commented on an issue   Re: Long form Resource Type reference fools "future parser" this is an override The future parser acceptance tests found a problem in parsing resource expressions with multiple resource bodies and a terminal ';'. Specifically: file { "/tmp/foo":; "/tmp/foo/bar":; } is a construction we have in several applied manifests: https://github.com/puppetlabs/puppet/blob/master/acceptance/tests/environment/can_enumerate_environments.rb for example. When Hailee Kenney and I dug into this, we found that the spec test: https://github.com/puppetlabs/puppet/blob/master/spec/unit/pops/parser/parse_resource_spec.rb#L52 is almost checking this, and fails if you add a terminal ';'. So that case should be expanded It looks like the problem is here in the grammar, in that a resource_body does not allow an optionally terminal ';' https://github.com/puppetlabs/puppet/blob/master/lib/puppet/pops/parser/egrammar.ra#L176 But when we tried the naive fix of adding endsemi after endcomma, we ended up with a shift/reduce conflict here: state 389 contains 1 shift/reduce conflicts ... state 389 27) resource_body : _expression_ COLON attribute_operations endcomma _ endsemi SEMIC shift, and go to state 405 SEMIC [reduce using rule 220 (endsemi)] $default reduce using rule 220 (endsemi) endsemi go to state 404 And at this point our brains exploded. So, Henrik Lindberg when you're back, perhaps we can go through this together? It would probably be quicker than bashing our way through. Add Comment   Puppet / PUP-2898 Long form Resource Type reference fools "future parser" this is an override When setting defaults for a resource type R, the short form works: {code} R { attr => value } {code} but not the long form: {code} Resource[R] { attr => value } Resource['r'] { attr => value } {code} This problem is due to the static transformation of a resource _expression_ since the two forms (override and default) have different rules than a ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.