Jira (PUP-2946) FileUtils implementation broke compare_stream

[Adrien Thebo (JIRA)]

Title: Message Title

Adrien Thebo commented on an issue   Re: FileUtils implementation broke compare_stream Maksym Melnychok the issue is that the change made only affected non-Windows systems (https://github.com/puppetlabs/puppet/blob/master/lib/puppet/file_system.rb#L9-L18), so if Windows was being used with Ruby 2.0 it would still use the Ruby 1.9 file implementation and thus wouldn't pick up the patched version of #compare_stream. I'm looking into the Ruby implementation to see if there is another way we can solve this issue without having to replace #compare_stream but it does look like the change made in https://github.com/ruby/ruby/commit/2142287c makes this very hard. Add Comment   Puppet / PUP-2946 FileUtils implementation broke compare_stream {{FileUtils.compare_stream}} implementation in ruby 1.9.3 was doing something along the lines of {code:ruby}     a = b = nil     while something       a = as.read size       b = bs.read size       return false if a != b     end {code} {{FileUtils.compare_stream}} in 2.0 instead does this: {code:ruby}     a = ""     b = ""     while some... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.