Jira (PUP-2972) Implementation of +=/-= is potentially confusing

[Andy Parker (JIRA)]

Title: Message Title

Andy Parker commented on an issue   Re: Implementation of +=/-= is potentially confusing I've done some more trawling around on Github. The most common use appears to be for concatenating arrays. However, there are several cases where string concatenation is done, which the new semantics of += don't support. Those can however be reworked to use string interpolation to achieve the same goal ($a = "$a$b"). There were also one or two uses that came at me out of left field. It turns out that the current system will allow += with qualified variable named. That has completely strange behavior: += with qualified vars class testing { $a = [1] } include testing $testing::a += [2] notice(inline_template('<%= @testing__a %>')) notice($testing::a) notice($a) produces: Notice: Scope(Class[main]): ["1", "2"] Notice: Scope(Class[main]): 1 Notice: Scope(Class[main]): Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.02 seconds Notice: Finished catalog run in 0.07 seconds Add Comment   Puppet / PUP-2972 Implementation of +=/-= is potentially confusing It seems to me that += and -= are more confusing than useful, and I would argue that they simply shouldn't exist. Right now (with "--parser future"), these operators implicitly create a new variable that may shadow one from an outer scope, appending/removing the RHS to the outer scope variable if it exists. If the variable has already been defined in t... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.