Jira (PUP-3177) Resource titles ending with square brackets fail

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on an issue   Re: Resource titles ending with square brackets fail Square bracket processing of the title seems to be there to support a type called component. That resource type is special as it acts as a factory for other types. There are tests that do things like this: ecomp = Puppet::Type.type(:component).new(:name => "Foo[exec]") The component type is not mentioned in user documentation. It seems that the intention was that this should work: $> puppet apply -e 'component {"Notify[hi]": message => wat }' Notice: Compiled catalog for example.com in environment production in 0.02 seconds Notice: wat Notice: /Stage[main]/Main/Notify[hi]/message: defined 'message' as 'wat' But the implementation does not check if the LHS name is component, and thus, any use of square brackets in the title triggers the behavior intended for the component type. The surprising behavior is when something other than component is used: $> puppet apply -e 'file {"Notify[hi]": message => wat } ' Notice: Compiled catalog for example.com in environment production in 0.02 seconds Notice: wat Notice: /Stage[main]/Main/Notify[hi]/message: defined 'message' as 'wat' And since the title is magic, and expects to be a well formatted resource reference, you can get all sorts of confusing error messages from the parsing of type/title. The logic for this is in puppet/resource.rb method extract_type_and_title. When I changed the logic to not do title munging at all there where > 1000 test failures. Changing that to only do title munging if type was not given revealed a handful of test cases that uses the combination :component, 'Type[title]'. I can see two ways of fixing this: support the :component idea by only doing title munging in resource.rb if the type is :component (that will make all unit and integration tests pass). remove the component type and only munge title if type is not given (and only munge type if title is not given) - other "munge"-cases are ambiguous and raise an error. Sanitize the API; there is too much flexibility - it only leads to confusion and bugs like this one. Add Comment   Puppet / PUP-3177 Resource titles ending with square brackets fail Hi, We're trying to install a package but the title has got square brackets which seems to make Puppet blow up, for example:   package { "Windows Server AppFabric v1.1 CU4 [KB 2800726]":     ensure => installed,     source => $fullInstallerPath,     install_options => $install_options,   } Trying to run this results in err... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.